You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a fix to #1435 by allowing to replay the previous messages for high-level Consumer.
In order to do this, when creating the consumer via IggyConsumerBuilder invoke allow_replay(), as otherwise, it won't be possible to consume the past records.
On top of this, a new method and server handler were added for deleting the consumer offset (as well as delete_offset() method was exposed in Consumer).
It might be useful e.g. when replaying the messages from the very beginning, cause invoking store_offset() with a 0 value, would result in skipping the first message (which would be treated as already consumed).
It seems that instead of delete_consumer_offset (or alongside it), a method like rollback_consumer_offset could be more appropriate. This method would allow rolling back to a specified offset without losing the entire history. What do you think?
It seems that instead of delete_consumer_offset (or alongside it), a method like rollback_consumer_offset could be more appropriate. This method would allow rolling back to a specified offset without losing the entire history. What do you think?
You can do this already with store_consumer_offset as the server doesn't care what the offset is (as long as it falls into the valid range) - so you can jump back and forth easily. The deletion is necessary, if you'd like to be able to start from the very beginning, as currently it's not possible (storing consumer offset for 0 means omitting the first record).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spetz
force-pushed
the
delete_consumer_offset
branch
from
This PR introduces a fix to #1435 by allowing to replay the previous messages for high-level
Consumer.In order to do this, when creating the consumer via
IggyConsumerBuilderinvokeallow_replay(), as otherwise, it won't be possible to consume the past records.On top of this, a new method and server handler were added for deleting the consumer offset (as well as
delete_offset()method was exposed inConsumer).It might be useful e.g. when replaying the messages from the very beginning, cause invoking
store_offset()with a0value, would result in skipping the first message (which would be treated as already consumed).